search

akka / akka-management

Akka Management is a suite of tools for operating Akka Clusters.
https://doc.akka.io/docs/akka-management/
Other
254 stars 160 forks source link

Clarify when to shut down Akka management #291

Open sebarys opened 6 years ago

sebarys commented 6 years ago

Hi,

I have a question: do I need to manually stop akka-management in my custom Task when using akka coordinated shutdown extension ( https://doc.akka.io/docs/akka/2.5.6/scala/actors.html#coordinated-shutdown )?

Additionally I found in akka-management documentation sentence: "In a dynamic environment you might stop instances of Akka Management, for example if you don’t want to free up resources taken by the HTTP server serving the Management routes." ( https://developer.lightbend.com/docs/akka-management/current/akka-management.html#stopping-akka-management ) Should not it be rather "if you want to free up" instead of "if you don’t want to free up" ?

Thanks, sebarys

patriknw commented 6 years ago

I don't think there is a need for explicit stopping from coordinated shutdown. The ActorSystem is anyway about to be stopped and Akka Management will be stopped with that at the end.

The negation must be wrong.

I also think that advice can be misleading if used together with Bootstrap.

chbatey commented 6 years ago

Yep new nodes will need the http endpoints for bootstrap so we can fix the docs under this issue

glammers1 commented 5 years ago

btw, the negation was deleted here #334 https://github.com/akka/akka-management/pull/334/files#diff-4fec015fc27c67d13e5612cfbc1dcfd5R125