search

akka / akka-persistence-jdbc

Asynchronously writes journal and snapshot entries to configured JDBC databases so that Akka Actors can recover state
https://doc.akka.io/docs/akka-persistence-jdbc/
Other
309 stars 142 forks source link

update h2 to v2 and fix schema creation for it #648

Closed aldenml closed 2 years ago

aldenml commented 2 years ago

This address https://github.com/akka/akka-persistence-jdbc/issues/639 and https://github.com/akka/akka-persistence-jdbc/pull/633

johanandren commented 2 years ago

I don't see that we clearly express that it is only for testing in the docs, so users may use it for prod even though it is a bad idea (tm). I think there needs to be some docs about how migration can be done.

octonato commented 2 years ago

I don't see that we clearly express that it is only for testing in the docs, so users may use it for prod even though it is a bad idea (tm). I think there needs to be some docs about how migration can be done.

I really thought we were very explicit about it, but apparent not. I also checked Akka Projections and we don't mention it either.

So, indeed, we will need to add docs about migration.

aldenml commented 2 years ago

is this additional documentation something that should be done as part of this PR?

octonato commented 2 years ago

is this additional documentation something that should be done as part of this PR?

No, we can do it in another PR. The only problem is that we should not merge this one before we are ready with the migration notice. If we merge and it happens that we need to cut a release because of a bug, we will impact the users directly and without notice.

If you want to add the migration notes to this PR, you are welcome. Otherwise, we keep it around until someone (we or community) has the bandwidth to do it.

octonato commented 2 years ago

I haven't said it before, so here it is. 😄

Thanks for the contribution. I hope we can get the migration guide soon and move forward with this PR.

nvollmar commented 2 years ago

We're also waiting to upgrade, is the only thing missing the migration notes?