search

akka / akka-persistence-jdbc

Asynchronously writes journal and snapshot entries to configured JDBC databases so that Akka Actors can recover state
https://doc.akka.io/docs/akka-persistence-jdbc/
Other
307 stars 139 forks source link

Add MySQL implementation #803

Closed steventwheeler closed 3 months ago

steventwheeler commented 4 months ago

References #802

lightbend-cla-validator commented 4 months ago

Hi @steventwheeler,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

steventwheeler commented 4 months ago

I'm working on getting the CLA approved on my end but this change appears to resolve the issues I was seeing in my application.

lightbend-cla-validator commented 4 months ago

Hi @steventwheeler,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

steventwheeler commented 4 months ago

My employer has signed the CLA.

octonato commented 4 months ago

My employer has signed the CLA.

Thanks for your contribution @steventwheeler.

However, for the CLA, the one that contributed needs to sign. The CLA checker will verify if user @steventwheeler has signed.

octonato commented 4 months ago

My employer has signed the CLA.

Thanks for your contribution @steventwheeler.

However, for the CLA, the one that contributed needs to sign. The CLA checker will verify if user @steventwheeler has signed.

So, what I'm saying is, if you have their authorization to contribute code to Akka, then you can sign the CLA and the code can be accepted by Lightbend.

steventwheeler commented 4 months ago

My employer has signed the CLA.

Thanks for your contribution @steventwheeler. However, for the CLA, the one that contributed needs to sign. The CLA checker will verify if user @steventwheeler has signed.

So, what I'm saying is, if you have their authorization to contribute code to Akka, then you can sign the CLA and the code can be accepted by Lightbend.

I have signed it as well.

steventwheeler commented 4 months ago

Or at least I linked my GitHub account to your site and filled in the form. Is there another step that is required?

johanandren commented 4 months ago

I manually verified there is an entry in the CLA database 👍

octonato commented 3 months ago

closing and reopen to re-trigger the CLA check

johanandren commented 3 months ago

Hey @steventwheeler, unfortunately we had an issue with the CI setup and didn't notice that the MySQLScalaJdbcDurableStateChangesByTagTest doesn't pass from this PR, I've disabled it in #806 where I fix the CI jobs, would be great if you could take a look, seems like the MySQLSequenceNextValUpdater doesn't work as expected.

Roiocam commented 3 months ago

Hey @steventwheeler, unfortunately we had an issue with the CI setup and didn't notice that the MySQLScalaJdbcDurableStateChangesByTagTest doesn't pass from this PR, I've disabled it in #806 where I fix the CI jobs, would be great if you could take a look, seems like the MySQLSequenceNextValUpdater doesn't work as expected.

@johanandren Seems like MySQL can only increase the sequence by inserting and from the database itself. I will say the Oracle and SQLServer will be more easy to implement. Need some magic tricks that make MySQL work.