search

akka / akka-persistence-jdbc

Asynchronously writes journal and snapshot entries to configured JDBC databases so that Akka Actors can recover state
https://doc.akka.io/docs/akka-persistence-jdbc/
Other
307 stars 139 forks source link

fix not working JournalDaoStreamMessagesMemoryTest #831

Closed Roiocam closed 2 months ago

Roiocam commented 2 months ago

JournalDaoStreamMessagesMemoryTest didn't work in the newDao because it uses legacyDao, we could create dao instance via reflection to make it works.

Roiocam commented 2 months ago

@johanandren @octonato would you like to take a look?

octonato commented 2 months ago

Was this test not being run? How was it passing before?

johanandren commented 2 months ago

@octonato if (newDao) pending

johanandren commented 2 months ago

I see I missed one thing though, we lost the class H2JournalDaoStreamMessagesMemoryTest, I'll follow up and re-introduce