search

akka / akka-quickstart-scala.g8

A minimal seed template for an Akka with Scala build
https://developer.lightbend.com/guides/akka-quickstart-scala/index.html
Other
57 stars 40 forks source link

update akka seed sbt to latest 1.x #22

Closed codesurf42 closed 6 years ago

lightbend-cla-validator commented 6 years ago

Hi @codesurf42,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

raboof commented 6 years ago

(manually checked the CLA is signed, not sure why github isn't showing it)

jiminhsieh commented 6 years ago

How about update sbt version of this project too instead of the seed project only?

jiminhsieh commented 6 years ago

@codesurf42 You might want to update sbt-giter8 too. Based on sbt plugin migration page, sbt-giter8 0.11.0-M2 begin to support sbt 1.x. In the same time, 0.11.0 was just released two weeks ago.

codesurf42 commented 6 years ago

Yeah, good idea @jiminhsieh, when I did that giter was not supporting sbt 1.x yet.

clemensutschig commented 6 years ago

When will the merge happen - we wait desperately for this for https://github.com/opendevstack

raboof commented 6 years ago

Sorry for the wait, thanks for the contribution!