akkadotnet / Akka.Quartz.Actor

Quartz scheduling actor
Apache License 2.0
55 stars 31 forks source link

Add support for preserving type info throughout serialization/deserialization process #334

Open danne931 opened 10 months ago

danne931 commented 10 months ago

Expected behavior I should be able to use a custom serializer defined with SerializerWithStringManifest or Serializer when IncludeManifest = true and have the appropriate type info passed into FromBinary.

Actual behavior If using a custom serializer defined with Serializer when IncludeManifest = true, the manifest type passed into FromBinary is not correct. If using a custom serializer defined with SerializerWithStringManifest, the manifest type string provided in my custom serializer's Manifest method is not passed into the manifest parameter of FromBinary.

Additional context I am using F# so fixing this so I can define a custom serializer to serialize/deserialize messages with a 3rd party library would be quite helpful.

danne931 commented 10 months ago

Potential fix: https://github.com/akkadotnet/Akka.Quartz.Actor/pull/335