search

akkadotnet / akka.net

Canonical actor model implementation for .NET with local + distributed actors in C# and F#.
http://getakka.net
Other
4.7k stars 1.04k forks source link

Please allow Akka.DI.StructureMap to depend on >= StructureMap v2.6.3. #1078

Closed davejclausen closed 8 years ago

davejclausen commented 9 years ago

Thanks for the Akka.DI.StructureMap NuGet!

One of our projects requires StructureMap dating back to v2.6.3.

I have tested StructureMapDependencyResolver on StructureMap v2.6.3 and it seems to work perfectly well.

Could the Akka.DI.StructureMap NuGet manifest allow >= StructureMap v2.6.3?

Would you prefer me to make a pull request for this?

Many thanks.

rogeralsing commented 9 years ago

As long as there are no API changes that prevents Akka.NET from using it then it should be fine. A PR would be welcome :)

davejclausen commented 9 years ago

Will do! StructureMapDependencyResolver works perfectly well (unchanged) with StructureMap v2.6.3. Thanks.

Update : my project went in a different direction, so I didn't take the time to learn how to do a Pull Request and take care of this (my extreme bad and apologies).

rogeralsing commented 9 years ago

Status on this one?

Aaronontheweb commented 9 years ago

Guess we still need to move the needle back in time on the NuGet package for this.

GeertVL-zz commented 9 years ago

Is this still open?

Danthar commented 8 years ago

This issue is still open. No PR has been made for this. So if anyone feels like updating this. Go right ahead.