search

akkadotnet / akka.net

Canonical actor model implementation for .NET with local + distributed actors in C# and F#.
http://getakka.net
Other
4.72k stars 1.04k forks source link

Docs: comments on router supervision are out of date #6976

Open Aaronontheweb opened 1 year ago

Aaronontheweb commented 1 year ago

Please describe what you are trying to understand

https://getakka.net/articles/actors/routers.html#supervision

"By default, pool routers use a custom strategy that only returns Escalate for all exceptions, the router supervising the failing worker will then escalate to its own parent"

Not true any more, as of https://github.com/akkadotnet/akka.net/issues/6295 in v1.4.50.

What did these pages not make clear?

Information is wrong - we use the default supervision strategy now and the documents should say so.

How can we do it better?

We just need to change this section to suggest that Pool routers now use Directive.Restart by default, like every other actor.

Aaronontheweb commented 1 year ago

Need to also clarify how to set the supervision strategy properly on routers:

So, is it also normal that overriding SupervisionStrategy the usual way is not having effect (e.g. breakpoint is not hit), as this must be done with Router.WithSupervisionStrategy?

We need a DocFx code reference for this type of stuff.