search

akkadotnet / akka.net

Canonical actor model implementation for .NET with local + distributed actors in C# and F#.
http://getakka.net
Other
4.7k stars 1.04k forks source link

[TestKit] SupervisorStrategy for TestActor is unused #7062

Open roee88 opened 8 months ago

roee88 commented 8 months ago

Version Information

v1.5

Describe the bug

https://github.com/akkadotnet/akka.net/pull/4148 added public IActorRef ChildActorOf(Props props, string name, SupervisorStrategy supervisorStrategy) and similar methods to TestKitBase. However, the supervisorStrategy does not take effect.

It looks like InternalTestActor doesn't override SupervisorStrategy() to actually use its private _supervisorStrategy. See https://github.com/akkadotnet/akka.net/blob/0782c7dc069618e20a3791aaab667076f487ad96/src/core/Akka.TestKit/Internal/InternalTestActor.cs#L24

Aaronontheweb commented 8 months ago

Thanks, we'll look into this