search

akkyie / AKPickerView

A simple yet customizable horizontal picker view.
MIT License
894 stars 106 forks source link

Fixed #62 #63

Closed mladen-stankovic closed 8 years ago

mladen-stankovic commented 8 years ago

I've fixed bug described in issue #62, can you please accept this pull request and update podspec file?

akkyie commented 8 years ago

Merged. Thank you for your contribution and I'm sorry for my late response!

mladen-stankovic commented 8 years ago

No problem, I'm happy to contribute :) Seems like tag 0.2.7 is on the same commit as tag 0.2.6.

Can you move tag 0.2.7 to the latest commit?

Thank you for this great horizontal picker!

akkyie commented 8 years ago

I fixed the wrong tag. It's my pleasure, thank you for using AKPickerView!

mladen-stankovic commented 8 years ago

Hi, there are 3 commits to master since 0.2.7 tag (tags 0.2.6 and 0.2.7 are the same). Can you please fix this?

Thanks

mladen-stankovic commented 8 years ago

Can you also commit podspec.json to the CocoaPods Specs? https://github.com/CocoaPods/Specs/tree/master/Specs/AKPickerView

mladen-stankovic commented 8 years ago

Hi, any chance of fixing 0.2.7 tag and updating CocoaPods Specs (see my 2 previous posts) ?

Thank you

akkyie commented 8 years ago

Done. Thanks https://raw.githubusercontent.com/CocoaPods/Specs/5b3d72e3ac73f2e97343bd7b09ec8d5c6ee31f4d/Specs/AKPickerView/0.2.7/AKPickerView.podspec.json

mladen-stankovic commented 8 years ago

Thank you for your quick response.

Sorry for bothering you but tag 0.2.7 is not correct.

https://github.com/Akkyie/AKPickerView/releases/tag/0.2.7

There it says Akkyie tagged this on May 14 · 3 commits to master since this tag

akkyie commented 8 years ago

Sorry for my repeatedly mistake… I fixed it.

mladen-stankovic commented 8 years ago

No worries, thank you for the fixes! Greetings to Japan :)