search

aklivity / zilla-examples

A collection of pre-canned Zilla feature demos. Deploy on K8s via Helm.
https://github.com/aklivity/zilla
Other
24 stars 13 forks source link

59 devex updates #82

Closed vordimous closed 1 year ago

vordimous commented 1 year ago

fixes #59

vordimous commented 1 year ago

Recommend using docker subdirectory (instead of compose) alongside k8s in zilla-examples scenarios.

I prefer to keep it as compose. Compose, Swarm, Kubernetes(helm), etc. are all container orchestration tools. Docker has grown into much more than that so it makes more sense to use the specific tool name. docker themselves are moving away from he docker-compose name making Compose the default name they use. They are even renaming the yaml file to compose.yaml.

We are still using the docker-compose name and command because other container runtimes have built aliases for them so we don't require users to use only the Docker engine.

llukyanov commented 1 year ago

Recommend using docker subdirectory (instead of compose) alongside k8s in zilla-examples scenarios.

I prefer to keep it as compose. Compose, Swarm, Kubernetes(helm), etc. are all container orchestration tools. Docker has grown into much more than that so it makes more sense to use the specific tool name. docker themselves are moving away from he docker-compose name making Compose the default name they use. They are even renaming the yaml file to compose.yaml.

We are still using the docker-compose name and command because other container runtimes have built aliases for them so we don't require users to use only the Docker engine.

In situations like these, it's always best to align with industry-accepted/familiar terminology, even at the slight cost of technical accuracy. Looking at how other infra guys, such as Kong, Quest, Surreal, etc. call out their installation methods, "Docker" is the more standard label, so let's use it.

-https://docs.konghq.com/gateway/3.4.x/install/ -https://questdb.io/docs/deployment/docker/ -https://surrealdb.com/docs/installation

vordimous commented 1 year ago

-https://docs.konghq.com/gateway/3.4.x/install/ -https://questdb.io/docs/deployment/docker/ -https://surrealdb.com/docs/installation

Those cases are all referring to the Docker engine directly. Using singular docker run commands or for Kong describing how to build their product into images with different linux hosts. Those implementations are much different from using docker compose to orchestrate services locally.