fix: alpine gcc does not define `_INTEGRAL_MAX_BITS`/`__WORDSIZE`

aklomp / base64

Fast Base64 stream encoder/decoder in C99, with SIMD acceleration

BSD 2-Clause "Simplified" License

866 stars 162 forks source link

fix: alpine gcc does not define `_INTEGRAL_MAX_BITS`/`__WORDSIZE` #78

Closed mayeut closed 2 years ago

mayeut commented 2 years ago

alpine gcc does not define _INTEGRAL_MAX_BITS/__WORDSIZE This leads to BASE64_WORDSIZE being defined to 0. Fallback to __LONG_WIDTH__ if it's defined or error out.

Builds on top of https://github.com/aklomp/base64/pull/75

aklomp commented 2 years ago

Do you mind if I detach this commit from the #75 patchset and merge it first?

aklomp commented 2 years ago

Nevermind, I merged #75 just now.

aklomp commented 2 years ago

I should have asked this before I merged the code :smile_cat: but what is the added benefit of testing on Alpine over testing on Ubuntu? As long as both distros expose a similar basic Linux environment, the distro flavor should be irrelevant. I'm worried that adding Alpine has made CI more complex without pulling its own weight in terms of added coverage.