aknorw / discojs

Easiest way to use the Discogs API in Javascript/Typescript :musical_note:
https://aknorw.github.io/discojs
MIT License
63 stars 9 forks source link

Build with webpack fails #1

Closed funkyfuture closed 6 years ago

funkyfuture commented 6 years ago

I'm hitting a bug when i try to build an app with webpack that depends on discogs.

package.json

{
  "name": "discojs-webpack-test",
  "description": "test to build a webpack based app w/ discojs as dep.",
  "main": "index.js",
  "devDependencies": {
    "webpack": "^4.20.2",
    "webpack-cli": "^3.1.2"
  },
  "dependencies": {
    "discojs": "^1.0.1"
  }
}

src/index.js

import Discosjs from 'discojs'

const client = new Discosjs(
  {userToken: 'zohJeim3le9ooxahf9Dae9ae6YiacaoRaht3naiw'}
)

$ npm install && npm webpack

npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN discojs-webpack-test@ No repository field.
npm WARN discojs-webpack-test@ No license field.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.4 (node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.4: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

added 393 packages from 296 contributors and audited 4267 packages in 12.069s
found 0 vulnerabilities

Hash: 6a5a4ec6f11f17cf9139
Version: webpack 4.20.2
Time: 3831ms
Built at: 2018-10-14 23:35:41
  Asset      Size  Chunks             Chunk Names
main.js  89.8 KiB       0  [emitted]  main
Entrypoint main = main.js
 [6] ./src/index.js 121 bytes {0} [built]
 [8] (webpack)/buildin/global.js 509 bytes {0} [built]
[16] ./node_modules/bottleneck/lib sync 160 bytes {0} [built]
    + 20 hidden modules

WARNING in ./node_modules/bottleneck/lib/RedisStorage.js 89:14-91:10
Critical dependency: the request of a dependency is an expression
 @ ./node_modules/bottleneck/lib/Bottleneck.js
 @ ./node_modules/bottleneck/lib/index.js
 @ ./node_modules/discojs/lib/index.js
 @ ./src/index.js
funkyfuture commented 6 years ago

i can't reproduce that anymore and i am having fun with the api. thanks for your efforts!

aknorw commented 6 years ago

Sorry about not answering, didn't see your issue. Have fun !