Have you submitted a pull req to the Knockout folks? Have they accepted it?

aknuds1 / knockout-isotope

Isotope binding for Knockout

8 stars 5 forks source link

Have you submitted a pull req to the Knockout folks? Have they accepted it? #4

Closed adrienne closed 11 years ago

adrienne commented 11 years ago

Just curious! Would love to not have to use a forked copy of KO.

aknuds1 commented 11 years ago

Hi adrienne, and thanks for your interest. I issued one pull request (regarding jQuery interaction) a good while ago, but I haven't heard anything after some initial feedback. I will check with the KO list again, especially as I found that my change breaks tests under certain circumstances and I can't fathom why.

I just issued another pull request tonight, for the other aspect of my fork (the beforeAdd callback). That one passes all tests, so hopefully I can get some traction on it soon.

aknuds1 commented 11 years ago

I was finally able to fix the test breakage, so I have now issued my second pull request. When these are (fingers crossed) merged into Knockout main, my fork should be obsolete.