search

aknuds1 / knockout-isotope

Isotope binding for Knockout
8 stars 5 forks source link

support for knockout 3.1 and isotope 2.0 #8

Open mogadanez opened 10 years ago

mogadanez commented 10 years ago

knockout 3.1 http://jsfiddle.net/mogadanez/nXRua/2/ isotope 2.0 http://jsfiddle.net/mogadanez/nXRua/3/

aknuds1 commented 10 years ago

Hi, do you think you could please fashion these into two separate pull requests for me to consider? Keep also in mind that the tests must pass.

Besides, I can't get your KO 3.1 demo to work. If I click next to Item 1, I expect a new item to appear, but nothing happens. If I after clicking next to Item 1, click on Item 1 to remove it, there's an exception thrown: TypeError: Cannot read property 'original-order' of undefined.

The Isotope 2 demo breaks right off the bat with the following exception: TypeError: Unable to process binding "isotope: function (){return { data:items,isotopeOptions:getOptions} }" Message: undefined is not a function.