akoenig / angular-deckgrid

A lightweight masonry-like grid for AngularJS.
http://akoenig.github.io/angular-deckgrid
MIT License
1.1k stars 190 forks source link

changing how columns are being added #60

Open mboudreau opened 10 years ago

mboudreau commented 10 years ago

It used to be that when columns were being added, they were being pushed into an array that was already on the scope. This causes angular to bind on every single push. Instead, I changed it so that there's only one write to the scope, making it bind only once.

futhr commented 9 years ago

Hi @mboudreau, just a hint, you change tabs so it hard to see actual changes, now it looks like you refactored everything, I doubt the owner will merge these changes even if its valid.

Shingaz commented 9 years ago

With this version, columns are not created again on model change. So you can't do any filtering or ordering on the data passed into the directive.

Edit: It seems to create duplicates: Error: [ngRepeat:dupes] Duplicates in a repeater are not allowed. Use 'track by' expression to specify unique keys.