search

akoenig / gulp-svg2png

A gulp plugin for converting SVGs to PNGs.
MIT License
54 stars 34 forks source link

Fix that makes the plug-in actually work. #24

Closed Andrew-Dunn closed 8 years ago

Andrew-Dunn commented 8 years ago

At the moment the plug-in literally does not work when called by Gulp.

This patch fixes that, by removing the use of pn to open the file, which has already been read into memory by gulp anyway.

svg2png already uses promises so there is no effect on synchronicity.

Added an extra error message to remind users that only Buffers are supported, not streams. I'm not sure if this will affect anybody.

An added bonus is that any changes made by gulp to the file will now be reflected by gulp-svg2png.

Addresses issues #23.

VitaliyR commented 8 years ago

1 month passed and still no answer to this? I've faced it too.

radu-tanasescu commented 8 years ago

I have this problem too.

VitaliyR commented 8 years ago

Raising the flag again. One more month passed and I still need to modify it locally.

radu-tanasescu commented 8 years ago

I use "gulp-svg2png": "1.0.2" and it works, this can be a temporary fix until version 2 works again.

VitaliyR commented 8 years ago

@radu-tanasescu 1.0.2 is not working - failing at converting smth.

akoenig commented 8 years ago

LGTM. Thanks for your effort and sorry to everybody for the late response.

akoenig commented 8 years ago

Released as 2.0.2.