search

akofman / cordova-plugin-add-swift-support

:hammer: Swiftify your Cordova app !
MIT License
116 stars 107 forks source link

Implement catching promise rejections #51

Closed ghost closed 6 years ago

ghost commented 6 years ago

Hi,

promise rejections of functions like getPlatformVersionsFromFileSystem are not caught, thus if something fails other cordova plugins are not added to the Bridging-Header.h and builds may fail.

getPlatformVersionsFromFileSystem failed for me due to a folder in the projectRoot containing a special character, but since the rejection was not caught this was very difficult to figure out.

Otherwise great plugin!

Regards

TheLiquidSky commented 6 years ago

This is relevant to my PR #52.

akofman commented 6 years ago

Fixed in PR #52