akofman / cordova-plugin-add-swift-support

:hammer: Swiftify your Cordova app !
MIT License
117 stars 110 forks source link

Fix for cordova projects located in paths with spaces #52

Closed TheLiquidSky closed 6 years ago

TheLiquidSky commented 6 years ago

We had an issue very similar to #47.

The shell execution of the cordova version script silently failed because the full path where our cordova project was located contained whitespaces (and other conflicting characters like '(' and '(' ). As a result, the promise returned by getPlatformVersionsFromFileSystem rejected and no changes to the xcode project were applied by this plugin. Wrapping the script command in quotation commands solved the problem for us.

sublimator commented 6 years ago

Bump!!

sublimator commented 6 years ago

Also, thank you @TheLiquidSky !

akofman commented 6 years ago

Thanks @TheLiquidSky ! Now I remember that this part of code had been copy/paste from the Cordova sources: https://github.com/apache/cordova-lib/blob/7.0.x/cordova-lib/src/cordova/platform_metadata.js#L68-L85 for this PR.

sublimator commented 6 years ago

Yay, thanks @akofman