search

akolpakov / django-unused-media

Remove unused media files from Django project
MIT License
126 stars 25 forks source link

Fix remove_empty_dirs argument action #44

Closed georgy-komarov closed 2 years ago

georgy-komarov commented 2 years ago

Bug: combination of default=False and action='store_false' parameters makes remove_empty_dirs argument always False https://github.com/akolpakov/django-unused-media/blob/54a24926cfcf5058186b0480083a5a0d4a1fef47/django_unused_media/management/commands/cleanup_unused_media.py#L44-L48

This condition is always false, so remove_empty_dirs() is never called https://github.com/akolpakov/django-unused-media/blob/54a24926cfcf5058186b0480083a5a0d4a1fef47/django_unused_media/management/commands/cleanup_unused_media.py#L106-L107 This pull request fixes a bug with argparse action setting for remove_empty_dirs by setting action='store_true'

akolpakov commented 2 years ago

You are right!

prokhn commented 2 years ago

Wow, I bet you won't see this pull request and I've lost 👀 :D

Can you please update pip version too?