Mishandled privilege escalation

[Talismanic]

On categ_ansible_test_code.txt file there are some sudo usage which is candidate of "Mishandled privilege escalation". However, I have not considered this part as anti-pattern.

shell: "sudo journalctl -u {{ item }}.service | tee {{ zuul_output_dir }}/logs/logs/{{ inventory_hostname }}/var/log/journal/{{ item }}.service.log"

Reason because:

• To decalre it as mishandled privilege escalation, we need to know the ansible version Developer was using. Because, before ansible 1.8 , is was not mandatory to avoid sudo in shell module.

• Also the line actually auditing journal logs which is normally not readable other than root user.

[akondrahman]

I understand. Can we know the Ansible version automatically?

[Talismanic]

1. Ansible version can be determined from ansible playbook through some command or OS.
2. Till now I cound not find any way to determine ansible version from the code base

[akondrahman]

OK. In that case we cannot consider wrong version as an anti-pattern. How many anti-patterns have we found so far Ansible?

[Talismanic]

So far I have found :

1. Assertion Roulette
2. External Dependency
3. Privilege Escalation
4. Local Testing

[akondrahman]

My gut feeling is there might be 1/2 more ... may be sth. related to Python testing as we will not skip Python altogether?

[Talismanic]

I am closing this issue and taking the category to #1