search

akonwi / git-plus

vim-fugitive like package for atom. make commits and other git things without the terminal
MIT License
537 stars 163 forks source link

Object.dirname is deprecated. #756

Open snrmwg opened 6 years ago

snrmwg commented 6 years ago

Argument to path.dirname must be a string

Object.dirname (C:\Users\90019971\AppData\Local\atom\app-1.28.0\resources\app.asar\src\electron-shims.js:9:10)
File.getParent (<embedded>:133739:45)
_callee2$ (C:\Users\90019971\.atom\packages\git-plus\lib\git-es.js:35:46)
tryCatch (C:\Users\90019971\.atom\packages\git-plus\node_modules\regenerator-runtime\runtime.js:62:40)
Generator._invoke (C:\Users\90019971\.atom\packages\git-plus\node_modules\regenerator-runtime\runtime.js:296:22)
Generator.next (C:\Users\90019971\.atom\packages\git-plus\node_modules\regenerator-runtime\runtime.js:114:21)
akonwi commented 6 years ago

Can you provide more info on how to reproduce this?

adamcheasley commented 5 years ago

I've also just run into this. It appears to happen when changing branches with a dirty repo.