search

akonwi / git-plus

vim-fugitive like package for atom. make commits and other git things without the terminal
MIT License
537 stars 163 forks source link

Cmd+C doesn't work in 8.2.0 #770

Closed oltodo closed 5 years ago

oltodo commented 5 years ago

Hi, since I've been updating this package to the 8.2.0 version, using the copy shortcut (Cmd+C) sets an empty value to the clipboard.

Rollbacking to the 8.1.0 solved the problem:

$ apm install git-plus@8.1.0
andyhofman commented 5 years ago

Same here!

nuxsmin commented 5 years ago

Just commenting out from line 60 to 62 within https://github.com/akonwi/git-plus/blob/e3f77dfda770c5f5e06f1574c9722988e1995b39/lib/views/output-view/Root.tsx#L60 does the trick

Not sure about side behaviors...

bonovski commented 5 years ago

I rolled back to 8.1.0

dorianfm commented 5 years ago

+1 and to add to this, in the key binding resolver git-plus:copy is given priority over core:copy , breaking copy on OS X versions:

screen shot 2018-12-10 at 12 30 57

meventi-stephan commented 5 years ago

Cmd+V doesn't also work. Made also a rollback to 8.1.0.

oltodo commented 5 years ago

Cmd+V should work fine according you have something in your clipboard

akonwi commented 5 years ago

whoa. sorry guys! I'll push a patch ASAP

akonwi commented 5 years ago

8.2.1 published

chrisgo commented 5 years ago

Thanks! My patch was to add this to the end of keymap.cson (Menu: Atom > Keymap)

...
'atom-workspace':
  'cmd-c': 'core:copy'

'atom-text-editor':
  'cmd-c': 'core:copy'