search

akosbalasko / yarle

Yarle - The ultimate converter of Evernote notes to Markdown
https://github.com/akosbalasko/yarle
MIT License
1.42k stars 81 forks source link

Attachment saved but not used #554

Closed Tokolino closed 10 months ago

Tokolino commented 10 months ago

I have a note that uses two attachments, according to the conversion log:

Conversion started at Thu Dec 28 2023 20:19:17 GMT+0100 (Mitteleuropäische Normalzeit) Converting note "Druckermeldung abschalten"... relative resource work dir: ../_filesFromEN absolute resource work dir: W:\daten\Ablage\Evernote\StandardYarle\notes_filesFromEN resource unknown_filename-35d7bb27.jpeg addid in hash 8fa5d5b102faf1c401c9c769aba7b524 resource Druckservereigenschaften.jpg addid in hash faf67d0ca150a9ba157bd9421fcbe36b mediaReference src ../_filesFromEN/unknown_filename-35d7bb27.jpeg added mediaReference src ../_filesFromEN/Druckservereigenschaften.jpg added Note saved to W:\daten\Ablage\Evernote\StandardYarle\notes\Standard\Druckermeldung abschalten.md Conversion finished at Thu Dec 28 2023 20:19:17 GMT+0100 (Mitteleuropäische Normalzeit) Note "Druckermeldung abschalten" converted successfully in 0.119 seconds. Notes processed: 1045

The mentioned file Druckservereigenschaften.jpg is present in the resources folder, but the markdown file does not contain a link to this file. Bug or feature?

The markdown file is attached: Druckermeldung abschalten.md

akosbalasko commented 10 months ago

Hi @Tokolino , Hm, it's hard to tell, I looks like that the enex file contains that jpeg, but there is no reference in the note. Could you pls send me the enex if you don't mind, to have a clear input to reproduce this issue? Thanks a lot!

Tokolino commented 10 months ago

Sorry, I can't send you the enex file because it contains a lot of private information. But, if this helps, it was an Evernot web clip from this page: https://blog.tintenalarm.de/allgemein/nervige-windows-statusmeldungen-der-drucker-abschalten-298.html The second picture in the middle with the Windows printer window is the one in question.

akosbalasko commented 10 months ago

Sure sure, no worries. Thank you, that should be enough, I'm on it.

akosbalasko commented 10 months ago

@Tokolino , Sorry, I'd need your Yarle config, because I cannot reproduce the issue with the default settings (meaning that it works for me, the link is there). Could you pls send me your config? Thanks a lot!

Tokolino commented 10 months ago

I could copy the problematic note in a new notebook that now only contains this note. I can reproduce the error with this export, too, so I can attach this one. Debug.zip yarle_20231228_213215.zip

akosbalasko commented 10 months ago

Hi @Tokolino , Thanks for the details and the example, I was able to reproduce the issue. The problem was that Evernote somehow saved the image within a link without any href, and in this case Yarle has not added the internal html (the image itself) as a content, but returned empty string. Now it is fixed, I added this example as a test to prevent such cases in the future. I'm not sure how it was saved to evernote at all, yesterday when I saved the webpage you shared, it was saved differently, but I realized in the past that Evernote is not really consequent in case of webclips. The fix is released in https://github.com/akosbalasko/yarle/releases/tag/v6.0.1 Thank you very much for your help to improve Yarle!

Tokolino commented 10 months ago

Hi @akosbalasko, unfortunately this problem got back with version 6.0.5...

akosbalasko commented 10 months ago

Hi @Tokolino , Hm..strange. Could you please send me your latest config? Because when I test the stuff with these config + enex, it works for me, the link is there in the MD file. Even if I comment out the fix introduced in v6.0.5. Thank you.

Tokolino commented 10 months ago

Ooops, sorry - my complaint applied to issue #557