Additional helper methods added to moment class

f3rr13r commented 7 years ago

Added some new methods to the moment class to assist the user in getting data about the moment instance that they have captured.

Description

NumberOfDaysInMonth() - Takes the month of the created instance and returns the number of days in the given month. Method also auto checks for the possibility of a leap year in order to determine which number of days February has.

NumberOfDaysInYear() - Takes the year of the created instance and returns the number of days in that year. Method checks the possibility of a leap year in order to determine how many days that specific year has.

IsLeapYear() - Simple helper method to determine whether or not the year that has been capture in the instance is or is not a leap year.

DaysLeftInMonth() - Takes the day of the created instance, as well as the month, and subtracts the day from the number of days in that month, returning the number of days the month has left from the moment.

Motivation and Context

Love the repo and find it really helpful, but found that an app which I am currently developing was in need of the information that these helper methods provide, so figured that others may need similar or the same functionality in the future.

How Has This Been Tested?

Testing has been done inside the project locally, but has not been scrutinized thoroughly. Will continue to test these methods for affecting factors such as time zone etc..

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x ] My code does not leave warnings unattended.
[x ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[ ] All new and existing tests passed.

akosma commented 7 years ago

Hi, thanks for this! Before accepting this PR we need you to provide unit tests for the new functionalities, and please rewrite your comments using the standard Swift documentation headers.

f3rr13r commented 7 years ago

Hey there! Have followed the unit testing and documentation header conformities for the new helper methods. Let me know if there is anything else I can do to meet the criteria. Harry

akosma / SwiftMoment