search

akoumjian / datefinder

Find dates inside text using Python and get back datetime objects
http://datefinder.readthedocs.org/en/latest/
MIT License
635 stars 167 forks source link

Day format not parsed #63

Closed mlberlin closed 5 years ago

mlberlin commented 6 years ago

A day specified as in 12th day of December, 2001 or in regex geek:

[0-9][0-9]?(st|nd|rd|th) day of

is not parsed.

Thnx for the great work!

jsenecal commented 6 years ago

I have a fix for that :) https://github.com/connectitnet/datefinder/commit/bb822249d5b18ab9f48c2a34d3001419bcd4c53d

akoumjian commented 6 years ago

@jsenecal I like the progress. Any interest in setting up a PR so we can discuss?

jsenecal commented 6 years ago

@akoumjian Of course! I thought that since most issues were left unresolved this project lacked an active maintainer - I'll work on cherry-picking changes I've made in a PR

akoumjian commented 6 years ago

I have been completely absent, much to my dismay. However, I was able to glance at your fork and like a lot of the changes so I would be happy to review a PR. I have been meaning to refactor this project for a while but life events have resulted in having a lot less free time for projects like this one.

Thanks!