akoutmos / doctor

Ensure that your Elixir project documentation is healthy
MIT License
179 stars 15 forks source link

Doctor reports missing specs on @impl functions. #17

Closed rsimmonsjr closed 4 years ago

rsimmonsjr commented 4 years ago

eg:

defmodule API.Application do
  @moduledoc false

  use Application

  @impl Application
  def start(_type, _args) do
    children = [
      API.Telemetry,
      API.Endpoint
    ]

    opts = [strategy: :one_for_one, name: API.Supervisor]
    Supervisor.start_link(children, opts)
  end

  @impl Application
  def config_change(changed, _new, removed) do
    API.Endpoint.config_change(changed, removed)
    :ok
  end
end

Doctor will report the two functions have no specs but by the very definition of the @impl they do.

akoutmos commented 4 years ago

Should be fixed in version 0.13.0. Thanks!