akoutmos / mjml_eex

This library is used to turn .mjml.eex files into EEx templates
MIT License
72 stars 12 forks source link

Relax phoenix_html to make it compatible with phoenix v1.7.0-rc.2 #13

Closed paridin closed 1 year ago

paridin commented 1 year ago

I recently add the mjml_eex to a new fresh project by default that uses the phoenix v1.7.0-rc.2.

Causing the following error.

Resolution completed in 0.089s
Because "the lock" specifies phoenix_html 3.3.0 and mjml_eex >= 0.2.0 depends on phoenix_html ~> 3.2.0, the lock is incompatible with mjml_eex >= 0.2.0.
And because your app depends on the lock, mjml_eex >= 0.2.0 is forbidden.
So, because your app depends on mjml_eex ~> 0.9.0, version solving failed.
** (Mix) Hex dependency resolution failed

I just drop the patch from phoenix_html to keep compatibility.

On the other hand, I take the dare to update the dependencies to the latest version available.

The lock now points to phoenix_html "3.3.0"

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 17426209695593ee442a9067e1bbb50916f1f080-PR-13


Totals Coverage Status
Change from base Build dc780c4652041cd0d094a9e4ef5769e342f6572f: 0.0%
Covered Lines: 123
Relevant Lines: 127

💛 - Coveralls
akoutmos commented 1 year ago

Thanks for the contribution!! I'll cut a release over the weekend with these changes :).

akoutmos commented 1 year ago

Just cut the release. Thanks again!