akoutmos / mjml_eex

This library is used to turn .mjml.eex files into EEx templates
MIT License
72 stars 12 forks source link

Make erlexec an optional dependency #9

Closed alappe closed 1 year ago

alappe commented 1 year ago

While the option to use the node compiler via erlexec is very nice, it could be an optional dependency for those who want it.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build fcc0a6d29f0b94b2dd1ddd18f4474e37e0283b46-PR-9


Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/compilers/node.ex 4 22 18.18%
<!-- Total: 4 22 18.18% -->
Totals Coverage Status
Change from base Build 5d3156fd56aa87ee8c00e6230ba037195b9825b5: -15.4%
Covered Lines: 95
Relevant Lines: 117

💛 - Coveralls
akoutmos commented 1 year ago

Sorry about the delay! I merged in PR #10 with your work along with the fix for the tests and an error message to let people know how to use the node compiler instead. Thanks for the contribution! Cutting a new release in the next 10 minutes :)