akoutmos / prom_ex

An Elixir Prometheus metrics collection library built on top of Telemetry with accompanying Grafana dashboards
MIT License
596 stars 104 forks source link

[FEATURE] support phoenix 1.7.0 #191

Closed glennr closed 1 year ago

glennr commented 1 year ago

I'm running into this when upgrading to Phoenix 1.7.0

Given this diff to mix.exs

-      {:phoenix, "~> 1.6.15"},                                                                              
+      {:phoenix, "~> 1.7.0"},
-      {:phx_live_storybook, "~> 0.4.5"},
-      {:plug_cowboy, "~> 2.5"},
+      {:phoenix_storybook, "~> 0.5.0"},
+      {:plug_cowboy, "~> 2.6"},

I get this error

 % mix deps.get
Resolving Hex dependencies...
Resolution completed in 1.358s
Because prom_ex >= 1.5.0 depends on plug_cowboy ~> 2.5.1 and your app depends on plug_cowboy ~> 2.6, prom_ex >= 1.5.0 is forbidden.
So, because your app depends on prom_ex ~> 1.7.1, version solving failed.

I'm hoping a version bump works here:

ivanhercaz commented 1 year ago

This one is related with #182.

I am excited to enjoy with the support for Phoenix 1.7!