Make plug_cowboy optional - Githubissues

akoutmos / prom_ex

An Elixir Prometheus metrics collection library built on top of Telemetry with accompanying Grafana dashboards

MIT License

596 stars 104 forks source link

Make plug_cowboy optional #237

Closed rodrigues closed 2 months ago

rodrigues commented 3 months ago

Hi 👋

With this PR, we can serve metrics in a different way, for instance using Bandit server with PromEx.Plug.

What problem does this solve?

With this change, the system doesn't need to have plug_cowboy and related dependencies just for PromEx.

Checklist

[ ] I have added unit tests to cover my changes.
[ ] I have added documentation to cover my changes.
[ ] My changes have passed unit tests and have been tested E2E in an example project.

Struggling a bit with the local environment for prom_ex now, could make it run in a local project.