akoyabio / phenoptrReports

Create analysis reports from inForm data.
https://akoyabio.github.io/phenoptrReports
zlib License
15 stars 7 forks source link

In Unmixing quality report, check that all images share same components #12

Closed ccoltharp-Akoya closed 5 years ago

ccoltharp-Akoya commented 5 years ago

If an image wasn't unmixed with the same number of components as others in the set, the results are NA. This can cause some confusion.

Can you check whether all images in a set share the same components?

There may be some use case where you'd want to compare crosstalk in images unmixed with different components selected, so maybe don't stop a user from trying, but show a prominent warning in the GUI?

AB-Kent commented 5 years ago

Do you have test data for this?

Rather than checking in the GUI (which does not open the files until you ask it to process) I think I would put a prominent note or warning in the resulting report.

ccoltharp-Akoya commented 5 years ago

I like that idea.

I used these two files for my test:

On Wed, May 8, 2019 at 8:29 AM Kent Johnson notifications@github.com wrote:

Do you have test data for this?

Rather than checking in the GUI (which does not open the files until you ask it to process) I think I would put a prominent note or warning in the resulting report.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/akoyabio/phenoptrReports/issues/12#issuecomment-490466547, or mute the thread https://github.com/notifications/unsubscribe-auth/AFR4OYTQMJELT6HZLCOIZFTPULBSRANCNFSM4HLMFFXA .

--

Carla Coltharp, PhD | Sr. Imaging Scientist

ccoltharp@akoyabio.com

Office: +1 774.278.2716

68 Elm Street, Hopkinton, MA 01748 USA

PerkinElmer’s Quantitative Pathology Solutions business has joined the Akoya Team