Added favicon from https://favicon.io/emoji-favicons/books

akrabat / slim3-bookshelf

Exploratory Slim Framework 3 application.

BSD 3-Clause "New" or "Revised" License

122 stars 19 forks source link

Added favicon from https://favicon.io/emoji-favicons/books #14

Closed 8ctopus closed 2 years ago

8ctopus commented 2 years ago

nice books favicon from https://favicon.io/emoji-favicons/books
prevents the code from running past the file exists check in public/index.php because favicon does not exist

https://github.com/akrabat/slim-bookshelf/blob/16984915687943c15caf5c85a7d11d299d03796f/public/index.php#L4-L12

akrabat commented 2 years ago

Needs an attribution at the bottom of the README to comply with the license.

8ctopus commented 2 years ago

Good point, I'm a bit at loss here. Maybe you can give me a hand:

The emoji graphics are from the open source project Twemoji. The graphics are copyright 2020 Twitter, Inc and other contributors. The graphics are licensed under CC-BY 4.0. You should review the license before usage in your project.

How should I put it?

8ctopus commented 2 years ago

Would it work, if I just copy paste that exact same line in your opinion?

akrabat commented 2 years ago

Would it works, if I just copy paste that exact same line in your opinion?

Yes. I think that would work in a Credits section at the bottom of the README.