HTML renderer weirdness

akrennmair / newsbeuter

Newsbeuter is an open-source RSS/Atom feed reader for text terminals.

http://www.newsbeuter.org/

MIT License

780 stars 97 forks source link

HTML renderer weirdness #305

Open Minoru opened 8 years ago

Minoru commented 8 years ago

I have text-width set to 72 and I observe this: 2016-05-21-003700_1366x740_scrot

Corresponding HTML looks like this:

domain. Earlier this year the site briefly added an additional <a href='whatever'>.MS TLD</a>, but this <a href='whatever2'>was suspended</a> after a few days.

Things to notice:

apparently, htmlrenderer doesn't care about text-width when adding link's text: the first line there is 74 characters long;
the comma should go on the same line as the link's text (in this case more like "TLD should have been put onto the next line together with the comma".)

npacenop commented 7 years ago

what's your html-renderer setting?

Minoru commented 7 years ago

It's set to "internal", the default.

Also shame on me for not including the version number, but I'm pretty sure at the time I already used versions built from Git.

npacenop commented 7 years ago

oh ok... I was observing very similar symptoms - text-width not being acknowledged - and I thought you might be experiencing the same problem. In my case the problem was, that I was using w3m as an html-renderer, and it seems that with an external renderer all the rendering happens externally (who would've thought :)), the newsbeuter parameter text-width just gets ignored. After some digging around and trying stuff out I found out that I can define the line length directly in the external renderer invocation (e.g. w3m -dump -cols 72 -T text/html) and that worked out just fine. As for your problem - I can't reproduce it locally. The internal renderer has been working fine with custom text-width settings for me.

Minoru commented 7 years ago

As for your problem - I can't reproduce it locally. The internal renderer has been working fine with custom text-width settings for me.

You mean you can't reproduce it with the same exact HTML I provided? It works most of the time for me too; this issue is just something that stuck out a bit and made me notice the problems.