akrennmair / newsbeuter

Newsbeuter is an open-source RSS/Atom feed reader for text terminals.
http://www.newsbeuter.org/
MIT License
780 stars 100 forks source link

Hidden tags visible in "Select a tag" #538

Open barlik opened 7 years ago

barlik commented 7 years ago

Newsbeuter version (copy from newsbeuter -v): newsbeuter 2.10-f8db System: Linux 4.10.8-1-ARCH (x86_64) Compiler: g++ 6.3.1 20170306 ncurses: ncurses 6.0.20170128 (compiled with 6.0) libcurl: libcurl/7.53.1 OpenSSL/1.0.2k zlib/1.2.11 libpsl/0.17.0 (+libicu/58.2) libssh2/1.8.0 (compiled with 7.53.1) SQLite: 3.18.0 (compiled with 3.18.0) libxml2: compiled with 2.9.4

Steps to reproduce the issue:

  1. Add a hidden tag to a feed. (open urls file) and add "!hidden" to some url.
  2. Open newsbeuter and type 't' to Select a tag:
  3. Now, you can see the hidden tag, but when you try to open it, the feed is empty.

Proposed solution:

Minoru commented 7 years ago

Hi. What's going on here?

barlik commented 7 years ago

Sorry, my browser went nuts.

Minoru commented 7 years ago

I'm in two minds about this.

On one hand, the docs don't say that tags starting with "!" are "hidden tags", so this isn't a bug.

On the other hand, I don't see why the act of hiding a feed and the act of tagging it were lumped up into one feature, i.e. tagging with a tag that starts with "!".

Can you explain how you're using these tags so I can understand the problem better and think of a proper solution?

barlik commented 7 years ago

From the manual:

Another special type of tag are tags that start with the exclamation mark. When such a tag is found, the feed is hidden from the regular list of feeds and its content can only be found through a query feed.

http://rss.orf.at/news.xml "!ORF News (hidden)"

I thought that I'm going to use that feature to hide non-important feeds and then create a query feed to list them. Currently, the "hidden" tags are listed (and empty) in tag view screen.

I'm okay with that feature being removed, then I'll find a different way of organising feeds.