akrennmair / newsbeuter

Newsbeuter is an open-source RSS/Atom feed reader for text terminals.
http://www.newsbeuter.org/
MIT License
781 stars 100 forks source link

Multiple highlight-article not working #600

Open sebastiankricner opened 6 years ago

sebastiankricner commented 6 years ago

Newsbeuter version (copy from newsbeuter -v):

newsbeuter 2.9 - http://www.newsbeuter.org/
Copyright (C) 2006-2010 Andreas Krennmair

newsbeuter ist Freie Software und unter der MIT/X Consortium License lizenziert.
Für mehr Information `newsbeuter -vv' eingeben.

Compilation date/time: Sep 22 2017 03:26:40
System: Linux 4.12.5-gentoo (x86_64)
Compiler: g++ 4.9.4
ncurses: ncurses 6.0.20150808 (compiled with 6.0)
libcurl: libcurl/7.53.0 OpenSSL/1.0.2k zlib/1.2.11 libidn2/0.16 libssh2/1.7.0 librtmp/2.3 (compiled with 7.53.0)
SQLite: 3.17.0 (compiled with 3.17.0)
libxml2: compiled with 2.9.4

Steps to reproduce the issue:

  1. Put multiple highlight-article configuration statements into the configuration file.

  2. Open a feed, with articles containing to be highlighted articles

  3. See, that only one highlight-article statement is working, colors from the second statement, with different colors influences the first highlight-article statement, the second highlight-article statement does not work

Other info you think is relevant:

I applied patch:

From 1d72eab529e9645eb2756935f0d44baf2f5a1f1c Mon Sep 17 00:00:00 2001
From: Luke Duncan <Duncan72187@gmail.com>
Date: Sat, 14 Nov 2015 01:54:53 -0500
Subject: [PATCH] Fix highlight article (Issue #166)

---
 src/itemview_formaction.cpp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/itemview_formaction.cpp b/src/itemview_formaction.cpp
index 1687382f..17fe537c 100644
--- a/src/itemview_formaction.cpp
+++ b/src/itemview_formaction.cpp
@@ -565,6 +565,7 @@ void itemview_formaction::set_regexmanager(regexmanager * r) {
    std::string attrstr;
    for (auto attribute : attrs) {
        attrstr.append(utils::strprintf("@style_%u_normal:%s ", i, attribute.c_str()));
+       i++;
    }
    attrstr.append("@style_b_normal[color_bold]:attr=bold @style_u_normal[color_underline]:attr=underline ");
    std::string textview = utils::strprintf("{textview[article] style_normal[article]: style_end[styleend]:fg=blue,attr=bold %s .expand:vh offset[articleoffset]:0 richtext:1}", attrstr.c_str());
Minoru commented 6 years ago

Hi! Newsbeuter is no longer maintained; I'm keeping a fork at newsboat/newsboat. Will try to reproduce you issue on the weekend.

sebastiankricner commented 6 years ago

Hello Batischev,

thanks for your information about the maintenance of newsbeuter.

I switched to newsboat and highlight-article works fine with newsboat.

Regards

Sebastian Kricner

Alexander Batischev, Fri, Sep 22, 2017 12:01:40PM -0700

Hi! Newsbeuter is no longer maintained; I'm keeping a fork at newsboat/newsboat. Will try to reproduce you issue on the weekend.

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/akrennmair/newsbeuter/issues/600#issuecomment-331533526

http://tuxwave.net -- The difference to think makes it real!