akretion / docky-odoo-template

This a project template to use with docky
2 stars 13 forks source link

[FIX] Always launch tests on default branch #86

Closed florian-dacosta closed 1 year ago

florian-dacosta commented 1 year ago

I believe this was removed by mistake in https://github.com/akretion/docky-odoo-template/pull/73 Else, I think it deserves that we talk about that, should not the test be run on default branch, only un MR ?

I think it is importante because you could have 2 green MR that onced merged in main branch conflict and make test fails. (then you don't see it before making the next MR.) I guess there may be other use cases... no ?

If it is decided that we don't launch test on default branch but only in MR, I can accept it, I just want it to be clear/discussed :)

bealdav commented 1 year ago

What kind of workflow do you suggest @hparfr ?