akretion / docky

Docky - Helper for docker-compose mainly used in odoo context
GNU Affero General Public License v3.0
56 stars 31 forks source link

requirement must use official version in order to publish them on pypi #154

Closed sebastienbeau closed 2 years ago

sebastienbeau commented 2 years ago

@hparfr to discuss We can no publish to pypi if we depend of a fork @PierrickBrun

hparfr commented 2 years ago

Yes but we can't use branch without the fork.

rvalyi commented 2 years ago

two possible workarounds:

  1. publish our own forked copier package under a different name. Cons: would force us to maintain it.
  2. monkey patch copier. Cons: monkey patching should be used wisely...

I didn't think further what would be the best...

rvalyi commented 2 years ago

@sebastienbeau I had to do this trivial fix to get it to work https://github.com/akretion/docky/pull/154/commits/a714674f92ec61ef047dbbd62dbabf8e57a77bca

bealdav commented 2 years ago

OK for me to not use a fork of copier. I really prefer to know that we use explicitely copier and not encapsulate it

sebastienbeau commented 2 years ago

@hparfr let's merge it ?

bealdav commented 2 years ago

yes maybe no docky init is an option if .env created by copier !? @sebastienbeau

sebastienbeau commented 2 years ago

Copier should not create the ".env" file as this file is not commited. It's not the logic of copier, copier is here to create, then update the versioned file. Moreover you want to generate an env file without updating your project, so copier is not the right tools for doing it.

So we have the following possibility for the .env

What do you think ?

bealdav commented 2 years ago

+ 1 for .env-sample with instruction inside

PierrickBrun commented 2 years ago

.env-sample seems good to me

It would be great if docky could refuse to start if there is no .env file also

sebastienbeau commented 2 years ago

Docky init removed, let's merge it

hparfr commented 2 years ago

please update the readme also ;-)

sebastienbeau commented 2 years ago

@hparfr readme is ok for you ?