akretion / docky

Docky - Helper for docker-compose mainly used in odoo context
GNU Affero General Public License v3.0
56 stars 31 forks source link

Upd use docker compose v2 fixes #159

Closed sebastienbeau closed 1 month ago

sebastienbeau commented 1 month ago

@mbcosta I have done some additionnal fixes on your PR

We can merge it and then release a new version.

The next step is to add some test (I will try to do it in a separated PR)

sebastienbeau commented 1 month ago

@paradoxxxzero @hparfr updated

mbcosta commented 1 month ago

Thank you @sebastienbeau , if you think will be better has a "clean" commits I can see to include your changes of:

During this time I'm also think in a way to make Docky more abstract, what a thought was allow change the default command $ docky run by a parameter in the docker-compose.yml file, for example if include something like:

odoo: environment: DOCKY_RUN: "run -P --rm --use-aliases -e NOGOSU=True odoo gosu odoo bash"

or in the .env

odoo: environment: DOCKY_RUN: $DOCKY_RUN

This command will overridden the Default, with this we can allow each Project has, if necessary, a specific parameters Saved in the file and in the big projects the most part of the Developers can ignore those specific parameters by just typing docky run or the Docky can be use for projects beyond Odoo case, but it's just a test, a speculation, let me know if you think it can be useful or not.

sebastienbeau commented 1 month ago

@mbcosta thanks for your feedback, I will squash the commit before merge them.

Regarding the option of docky run, I think we can do something better

sebastienbeau commented 1 month ago

I have added a task for the option on docky run /exec https://github.com/akretion/docky/issues/160