search

akretion / odoo-builder

Builder image for speeding up Odoo build with a multi-step image
0 stars 0 forks source link

odoo-builder should be Odoo serie specific #2

Open rvalyi opened 4 years ago

rvalyi commented 4 years ago

basically if you have whatever host (Gitlab, Dokku host, Kubernetes node) where you have the odoo-builder image, if you need to deploy several Odoo instances with different Odoo series on this same host you will have a conflict in the /builder/ files of this odoo-builder image.

An alternative could be to have a file layout like /builder/SERIE/` where you could host the clones of several Odoo series. However this would often be sub-optimum as you will likely have only one Odoo serie instead. But the point is OFTEN != ALWAYS.

My proposal is we fix this by having versioned odoo-builder in different branches. Like a 10.0 branch, 12.0 branch, 1 14.0 branch...

cc @sebastienbeau

rvalyi commented 4 years ago

Hum I see in fact you fetch several branches in the .git of all repos... This could work, but then we should be more picky and avoid branches with a lot of trash from old Odoo versions...

See the problem with that in https://github.com/akretion/odoo-builder/issues/3

rvalyi commented 4 years ago

Also, even if you fetch several serie branches and even supposing we filter them, I tend to think a serie specific odoo-builder is still better. Indeed, each time you push/deploy (possibly dozens times a day in Gitlab), you will need to checkout the serie branch from the .git for all repos. Given how many repos and files there are, even if this is network savy, this is still quite bit brutal in term of disk operations...