search

akretion / roulier

API for package delivery
http://akretion.github.io/roulier/
GNU Affero General Public License v3.0
21 stars 21 forks source link

add a delivery comment field for dpd #156

Closed matthieu1611 closed 2 years ago

florian-dacosta commented 2 years ago

The delivery instructions / comment on the shipping is not something specific to dpd, I guess multiple carriers may allow to send this kind of information.

I think we must have a generic name for this. Something like : car:vinfo1>{{ address.deliveryInstruction }}</car:vinfo1>

Also, I don't think we want to over-complicate roulier and we should implement what we need step by step. So if the need today is to send to roulier just one deliveryInstruction, implementing only the vinfo1 is enough. We eventually can manage into roulier to send deliveryInstruction[0:35] to vinfo1 et deliveryInstruction[0:400] to customLabelText and manage only on key in the input api if necessary.

what do you think @matthieu1611

matthieu1611 commented 2 years ago

I take into account this remark and create PR 159. I 'll close this one