search

aksakalli / gtop

System monitoring dashboard for terminal
MIT License
9.74k stars 326 forks source link

OSX gtop not resizing window after node upgrade #58

Closed embano1 closed 2 years ago

embano1 commented 7 years ago

Environment

Description

After node upgrade (from 8.1.2 to 8.8.1) gtop does not automatically adapt to window resizes. Tried in the default OSX terminal app, iTerm, tmux. Same result. The reason I ran into this, was when I installed gtop on another machine with a recent node version. On the machine with the old node version, the app automatically adjusted to window resizes. After upgrading node also on this machine, it´s not working anymore.

Since I am not a node expert, I´m having a hard time figuring out which module might have caused this change.

TimothyEarley commented 7 years ago

I had the problem of resizing too (on Arch Linux). However, I am not sure whether it was also caused by a node upgrade. While trying to fix the problem I added a line here, which seems to have fixed the issue:

process.on('SIGWINCH', function() {});

I won't open a pull request for this since I have no idea how or why this fix worked, but it would be nice if someone more competent would do so.

embano1 commented 7 years ago

@TimothyEarley hey, works like a charm! thx a ton!!!