search

aksakalli / jekyll-doc-theme

Jekyll theme for creating project documentation websites
https://aksakalli.github.io/jekyll-doc-theme/
MIT License
288 stars 261 forks source link

Update to Bootstrap 4 #30

Open coliff opened 5 years ago

coliff commented 5 years ago

It'd be a bit of work, but it'd be great to update this theme to use Bootstrap 4.

aksakalli commented 5 years ago

Hi coliff,

Thank you for your contribution and your suggestion.

The Bootswatch Project also supports Bootstrap 4. It is definitely doable. I wonder the advantages over Bootstrap 3. Should I maintain both versions or better switch to Bootstrap 4 for all. If you want to create a PR, I would really appreciate your help.

coliff commented 5 years ago

Hi @aksakalli - Bootstrap 4 is a big improvement in many ways, it works better across smaller screen sizes due to the extra viewport media query breakpoint. I don't think it's worth maintaining a separate version of the theme for Bootstrap 3.

I'm considering using this theme for a project and if I do, I'd like to update it to Bootstrap 4, in which case of course I'll open a PR. Thanks for the work you've done on this theme so far. :-)

spk2dc commented 4 years ago

Was this ever accomplished? I'm new to jekyll and trying to use this theme but haven't been able to successfully update it to Bootstrap 4 which I will need for some of the features I want to add to my site.