Rewrite

[aksenol]

Current version in the CWS works without caching but the caching logic should be changed because it is still not working for people with too many files in their Drive's. So a new logic for caching is required. How should we handle caching? We also need to change oauth as Paul suggested.

I have the time after this week and I was thinking I could completely redesign the logic and rewrite the extension.

[paulirish]

Rewrite works for me.

We can use some ES6: classes, for..of loops, template strings, generators & yield, Promises, fetch.

Lets use this issue to sketch out a design for it, yeah?

[aksenol]

OK but never used any ES6 before. Actually didn't use JS for a long time :) I will have to learn and remember.

So what would be first step at design?

[aksenol]

I will check the API again to see what might be of use to us when I have some time.

[evanhammer]

Let me know if I can help. I haven't written a Chrome app before but I am super-fluent in javascript.

[paulirish]

Quick thoughts, very incomplete:

• Class: drive API interaction.
  • Any async fetches we use generators and yield to better structure the async
• Class: UI and Omnibox interaction
  • handles most chrome API interactions and presentation involvement.
• Class: caching layer
  • the storage and cache invalidation bits.
• app.init() and app.omniboxkeydown() i suppose.

For me one goal here is to make the code a bit easier to follow. Another is to use some new shit.

@evanhammer does that gel with what you're thinking? I wont have time to write the skeleton so im interested in your ideas.

[aksenol]

Maybe the caching layer and drive interaction classes should share a parent class and provide the same interface to use. So we can use the api and cache interchangeably.

[paulirish]

sgtm!

[evanhammer]

@paulirish i like it. warning: i have no experience with chrome apps.

would we want a settings view for switching your google account? doesn't seem necessary to spec out now.

[paulirish]

yeah we can defer that until later.​

[aksenol]

I have a final tomorrow, and after that I'll be laying out the design, then we can start coding.

[paulirish]

sgtm​

[paulirish]

@axenol got an update?

[aksenol]

For the last few weeks, I've been staying in a place with no Internet access, so I couldn't do anything. But we are moving today, once I settled in I will start working on this probably by starting the initial code base and getting your feedback after. Sorry for keeping you in the dark, I was in the dark myself :)

On Wed, Jun 24, 2015, 02:50 Paul Irish notifications@github.com wrote:

@axenol https://github.com/axenol got an update?

— Reply to this email directly or view it on GitHub https://github.com/axenol/drive-quick-search/issues/16#issuecomment-114676732 .

[aksenol]

I've been checking if we can use ES6 features with Chrome extenstions but couldn't find anything useful. @paulirish do you have any idea if we can use it?

Found this compatibility table. http://kangax.github.io/compat-table/es6/#chrome43

[aksenol]

I will try to create a new branch with the skeleton code laid out in a few days, maybe even today. But I will refrain from using ES6 for now, does that sound good?

Changed my mind I will start with creating some wiki pages for classes that we are planning to have.