search

akserg / angular.dart.ui

Port of Angular-UI to Dart.
angulardartui.com
Other
101 stars 37 forks source link

dropdown-directive add/remove 'open' to parent element's class attribute #46

Closed nleguen closed 10 years ago

nleguen commented 10 years ago

I'm using angular-ui package v.0.2.0+7 and I have a html code like this:

<body ng-app>
  <div id="test" class="well">
    <button class="btn" type="button"  dropdown-toggle>Test Menu</button>
    <ul class="dropdown-menu">
      <li><a href="#">Item 1</a></li>
      <li><a href="#">Item 2</a></li>
    </ul>
  </div>
</body>

When I click the button, the menu is not displayed but I can see that "open" is added to div id="test" class attribute. Clicking again the button remove "open" from the div class attribute. Is this a bug or did I do something wrong ?

nleguen commented 10 years ago

Actually implementation from https://github.com/angular-dart-ui/bootstrap is working ... are angular.dart.ui and angular-dart-ui related ?

akserg commented 10 years ago

Hi,

I found a lot of issue with quotes and anchors in you code. After changes it's look like that:

*

Next, read carefully Bootstrap documentation about Dropdownshttp://getbootstrap.com/components/#dropdowns :

So, you code must be changed like that:

Implementation in https://github.com/angular-dart-ui/bootstrap uses '.dropdown' in parent component as well.

Regards, Sergey.

On 5 March 2014 10:38, nleguen notifications@github.com wrote:

Actually implementation from https://github.com/angular-dart-ui/bootstrapis working ... are angular.dart.ui and angular-dart-ui related ?

Reply to this email directly or view it on GitHubhttps://github.com/akserg/angular.dart.ui/issues/46#issuecomment-36720378 .

nleguen commented 10 years ago

Oops yes, I had some problems with copy/paste and retype the code too fast. Obviously the quotes and anchors were correct on the original code (I've fixed them in the first comment). The problem was just that <div class="dropdown"> was missing. It works now :) Thank you for your help. Btw. you didn't answer about the link with the other project. Are these project related ?

akserg commented 10 years ago

We incorporated ngular-dart-ui and the author joined to us last month. Now he is busy with moving Tab component to Angular Dart UI.

Regards.

On 5 March 2014 13:43, nleguen notifications@github.com wrote:

Oops yes, I had some problems with copy/paste and retype the code too fast. Obviously the quotes and anchors were correct on the original code (I've fixed them in the first comment). The problem was just that

was missing. It works now :) Thank you for your help. Btw. you didn't answer about the link with the other project. Are these project related ?

Reply to this email directly or view it on GitHubhttps://github.com/akserg/angular.dart.ui/issues/46#issuecomment-36734262 .