Open enjoythelive1 opened 6 years ago
The issue with the test are with the versions of the dependencies that are downloaded for testing. If the @angular/common
dependency is specified to only match the other dev dependencies, the tests runs
I have been looking for something similar to this - Would be great if it could be merged in!
…imation is much smother
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Fixes #61
complete
method is called, whenstart
is called.completed
callback from thestart
method, because that callback will never be called under the new algorithm for the bar growth.What is the current behavior? (You can also link to an open issue here) When
start
is called, the loading bar loads for 50 seconds until it looks completed.What is the new behavior (if this is a feature change)? When
start
is called, the bar stays loading forever, showing increments of lower amounts as time progresses allowing for it to stay doing increments to the bar forever. (9%, 17%, 25%, 32%, 38%, 44%, 49%, 53%, 58%, 61%, 65%, 68%, 71%, 74%, 76%, 78%, 80%, 82%, 84%, 85%, 86%, 88%, 89%, ...) but no 100%.Other information:
The velocity of this change can be modified by changing the field
growVelocity
in the service, and the higher the value, the more quickly the bar will look full.