changed the reference to rxjs

imranmomin commented 6 years ago

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Fixed the issue related when the version Angular & RxJs is updated to latest i.e. v6 when installling on angular6 getting compilation error : 'Observable is not a member of rxjs/Observable' or 'Subject is not a member of rxjs/Observable '
What is the current behavior? (You can also link to an open issue here)

67 - where the library is still referring the RxJs module under wrong location when updated to RxJs v6
What is the new behavior (if this is a feature change)? No change in the functionality. Just updated the import change to point the new location
Other information:

bougnat12 commented 6 years ago

Maybe we need to upgrade to Angular6/RxJS6 in the package.json file too to avoid Tracis CI failure?

inunotaisho commented 6 years ago

@bougnat12 @imranmomin I have just done an angular 6/ rxjs upgrade on my local environment. The problem we now have is we 4 of the 16 test are failing.

Feel free to give me a buzz if you want to help me fix this. We are using this package at the non-profit I am volunteering at.

New package.json


  "name": "ng2-slim-loading-bar",
  "description": "Angular2 component shows slim loading bar at the top of the page",
  "version": "0.0.0-semantically-released",
  "scripts": {
    "test": "karma start",
    "test-watch": "tsc && karma start --no-single-run --auto-watch",
    "commit": "npm run prepublish && npm test && git-cz",
    "prepublish": "ngc && npm run build",
    "build": "webpack && cp style.css bundles/style.css",
    "semantic-release": "semantic-release pre && npm publish && semantic-release post",
    "analyze": "ANALYZE=true webpack"
  },
  "repository": {
    "type": "git",
    "url": "https://github.com/akserg/ng2-slim-loading-bar.git"
  },
  "keywords": [
    "angular",
    "angular2",
    "angular5",
    "angular6",
    "slim",
    "loading",
    "bar",
    "progress"
  ],
  "author": "Sergey Akopkokhyants",
  "license": "MIT",
  "bugs": {
    "url": "https://github.com/akserg/ng2-slim-loading-bar/issues"
  },
  "main": "bundles/index.umd.js",
  "module": "index.js",
  "typings": "index.d.ts",
  "homepage": "https://github.com/akserg/ng2-slim-loading-bar",
  "peerDependencies": {
    "@angular/core": "^6.1.0"
  },
  "devDependencies": {
    "@angular/common": "^6.1.0",
    "@angular/compiler": "^6.1.0",
    "@angular/compiler-cli": "^6.1.0",
    "@angular/core": "^6.1.0",
    "@angular/platform-browser": "^6.1.0",
    "@angular/platform-browser-dynamic": "^6.1.0",
    "@angular/platform-server": "^6.1.0",
    "@types/hammerjs": "^2.0.33",
    "@types/jasmine": "2.5.37",
    "@types/node": "6.0.46",
    "awesome-typescript-loader": "^4.0.0",
    "codelyzer": "4.4.4",
    "commitizen": "2.8.6",
    "core-js": "2.5.7",
    "cz-conventional-changelog": "1.2.0",
    "istanbul-instrumenter-loader": "0.2.0",
    "jasmine-core": "2.5.2",
    "karma": "1.3.0",
    "karma-chrome-launcher": "2.0.0",
    "karma-coverage": "1.1.1",
    "karma-firefox-launcher": "1.0.0",
    "karma-jasmine": "1.0.2",
    "karma-mocha-reporter": "^2.1.0",
    "karma-remap-coverage": "~0.1.2",
    "karma-sourcemap-loader": "^0.3.7",
    "karma-webpack": "^2.0.1",
    "loader-utils": "~0.2.16",
    "reflect-metadata": "^0.1.8",
    "rxjs": "^6.0.0",
    "rxjs-compat": "^6.0.0",
    "semantic-release": "^15.0.0",
    "source-map-loader": "0.1.5",
    "ts-helpers": "1.1.2",
    "tslint": "~4.0.0",
    "tslint-loader": "3.3.0",
    "typescript": "^2.9.0",
    "webpack": "^3.2.0",
    "webpack-bundle-analyzer": "^2.9.0",
    "zone.js": "^0.7.6"
  },
  "config": {
    "commitizen": {
      "path": "./node_modules/cz-conventional-changelog"
    }
  }
}```

imranmomin commented 5 years ago

closing the PR - repo is not active anymore

akserg / ng2-slim-loading-bar

changed the reference to rxjs #68

67 - where the library is still referring the RxJs module under wrong location when updated to RxJs v6