search

akserg / ng2-toasty

Angular2 Toasty component shows growl-style alerts and messages for your app.
MIT License
283 stars 102 forks source link

Angular2 RC.1 #12

Closed martinnormark closed 8 years ago

martinnormark commented 8 years ago

Migrated everything to Angular 2 RC.1

The convenience methods: isString, isNumber and isFunction seems to be gone, hence to use of lodash. I couldn't find any similar expose of angular2/src/facade/lang in RC1 - I could be mistaken though.

I'm new to karma, so I probably got the mapping in SystemJS completely wrong. I tried using "@angular/*": "node_modules/@angular/*" but running tests was throwing a bunch of 404s for almost every angular dependency.

Karma setup was done separately in c979151db342a929db93ede0404f805b61400379.

akserg commented 8 years ago

Hi Martin, Thank you very much for your PR.

I'm very busy now and will have the chance look at your changes only on Thursday.

martinnormark commented 8 years ago

👍 Cool, no problem!