akserg / ng2-toasty

Angular2 Toasty component shows growl-style alerts and messages for your app.
MIT License
283 stars 102 forks source link

RxJs 6 Support #99

Open iamwyza opened 6 years ago

iamwyza commented 6 years ago

bug

module can't be used with RxJs v6. (npm update)

Add module to a Angular 6 environment without rjxs-compat. Then do npm install/update:

node_modules/ng2-toasty/src/toasty.service.d.ts(1,10): error TS2305: Module '"/node_modules/rxjs/Observable"' has no exported member 'Observable'.

module works

see above

Rzpeg commented 6 years ago

module can be used with Angular 6, with rxjs-compat installed

intuitivepixel commented 6 years ago

module can be used with Angular 6, with rxjs-compat installed

that is true I can confirm that it works, but are there any plans to update to rxjs 6 anytime soon?

iamwyza commented 6 years ago

@Rzpeg - Well yes, that can be said of alot of things, but that's a lousy answer. -compat adds alot of bloat and, also, -compat will only work for rxjs 6. rxjs7 will not have a -compat release. (the release notes for 6 stated this). Out of all the modules I presently am using in my app, only this and one other don't properly handle this.

So, the issue stands.

Rzpeg commented 6 years ago

This repo looks dead, no activity at all.

I have migrated my project to https://github.com/scttcper/ngx-toastr

emonney commented 6 years ago

I have ported this library here with angular6 and rxjs6 support. ngx-toasta. And also with some extra enhancements.

npm install ngx-toasta