search

akshat0047 / UNDERDOGS-V2

The version 2 of the official underdogs webapp
0 stars 9 forks source link

Removed old members from the website #5

Closed V3dant closed 4 years ago

V3dant commented 4 years ago

1 Removed Siddhant Singh, Anushka Shukla & Dania Alam from the underdog crew.

V3dant commented 4 years ago

Removed these guys from the crew page. Siddhant Singh Anushka Shukla Dania Alam

V3dant commented 4 years ago

And removed Srishti Shukla from the carousel.

akshat0047 commented 4 years ago

@V3dant Its great that you have accomplished the task but this is the wrong workflow to work on an OpenSource project. As mentioned in my text, you need to tell if you're working on an issue by commenting on it and the maintainer provides you the approval for the same.

Also 1 PR = 1 Issue

I know the issues were minor but they were made so to help budding contributors to OpenSource Please follow these steps:-

(Your doubts are welcome)

V3dant commented 4 years ago

Okay, I'll keep that in mind from next time. But I've made the changes you asked for and created a pull request there's no going back for me.

akshat0047 commented 4 years ago

There is for sure just do a hard reset to one previous commit and force push to your origin.